search

zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
34 stars 20 forks source link

feat: Support hook.yaml update in configmap #24

Closed mintcckey closed 9 months ago

sre-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mintcckey To complete the pull request process, please assign zwd1208 after the PR has been reviewed. You can assign the PR to them by writing /assign @zwd1208 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 9 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a974e4f) 80.16% compared to head (86e6ab4) 80.06%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #24 +/- ## ========================================== - Coverage 80.16% 80.06% -0.11% ========================================== Files 47 47 Lines 4760 4770 +10 ========================================== + Hits 3816 3819 +3 - Misses 797 802 +5 - Partials 147 149 +2 ``` | [Files](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) | Coverage Δ | | |---|---|---| | [apis/milvus.io/v1beta1/milvus\_types.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-YXBpcy9taWx2dXMuaW8vdjFiZXRhMS9taWx2dXNfdHlwZXMuZ28=) | `75.65% <ø> (ø)` | | | [pkg/controllers/deployments.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL2RlcGxveW1lbnRzLmdv) | `81.81% <ø> (ø)` | | | [pkg/controllers/status\_cluster.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL3N0YXR1c19jbHVzdGVyLmdv) | `87.28% <100.00%> (+0.03%)` | :arrow_up: | | [pkg/controllers/utils.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL3V0aWxzLmdv) | `94.05% <100.00%> (-0.05%)` | :arrow_down: | | [pkg/external/minio.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2V4dGVybmFsL21pbmlvLmdv) | `91.30% <100.00%> (ø)` | | | [pkg/controllers/conditions.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL2NvbmRpdGlvbnMuZ28=) | `88.53% <40.00%> (-1.19%)` | :arrow_down: | | [pkg/controllers/configmaps.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL2NvbmZpZ21hcHMuZ28=) | `63.06% <42.85%> (-1.37%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.