search

zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
45 stars 23 forks source link

Support hook config #26

Closed mintcckey closed 12 months ago

codecov[bot] commented 12 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d56ab8a) 80.11% compared to head (fb6aca0) 80.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #26 +/- ## ========================================== - Coverage 80.11% 80.06% -0.06% ========================================== Files 47 47 Lines 4763 4770 +7 ========================================== + Hits 3816 3819 +3 - Misses 799 802 +3 - Partials 148 149 +1 ``` | [Files](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/26?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) | Coverage Δ | | |---|---|---| | [apis/milvus.io/v1beta1/milvus\_types.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/26?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-YXBpcy9taWx2dXMuaW8vdjFiZXRhMS9taWx2dXNfdHlwZXMuZ28=) | `75.65% <ø> (ø)` | | | [pkg/controllers/deployments.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/26?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL2RlcGxveW1lbnRzLmdv) | `81.81% <ø> (ø)` | | | [pkg/controllers/configmaps.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/26?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL2NvbmZpZ21hcHMuZ28=) | `63.06% <42.85%> (-1.37%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

haorenfsa commented 12 months ago

/approve /lgtm

sre-ci-robot commented 12 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, mintcckey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment