search

zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
34 stars 20 forks source link

Support kafka sasl health probe #38

Closed haorenfsa closed 8 months ago

haorenfsa commented 8 months ago

/cc @zwd1208 @jaime0815

Fix #32

sre-ci-robot commented 8 months ago

@haorenfsa: GitHub didn't allow me to request PR reviews from the following users: jaime0815.

Note that only zilliztech members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/zilliztech/milvus-operator/pull/38): >/cc @zwd1208 @jaime0815 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sre-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 8 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (10694ce) 80.03% compared to head (8f56e0e) 80.02%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #38 +/- ## ========================================== - Coverage 80.03% 80.02% -0.01% ========================================== Files 47 47 Lines 4778 4867 +89 ========================================== + Hits 3824 3895 +71 - Misses 804 819 +15 - Partials 150 153 +3 ``` | [Files](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech) | Coverage Δ | | |---|---|---| | [pkg/controllers/conditions.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL2NvbmRpdGlvbnMuZ28=) | `88.53% <100.00%> (ø)` | | | [pkg/external/kafka.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2V4dGVybmFsL2thZmthLmdv) | `100.00% <100.00%> (ø)` | | | [pkg/external/minio.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2V4dGVybmFsL21pbmlvLmdv) | `91.30% <100.00%> (ø)` | | | [pkg/controllers/status\_cluster.go](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech#diff-cGtnL2NvbnRyb2xsZXJzL3N0YXR1c19jbHVzdGVyLmdv) | `83.96% <34.78%> (-3.32%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/zilliztech/milvus-operator/pull/38/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zilliztech)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.