search

zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
45 stars 23 forks source link

Fix background deletion blocked #51

Closed haorenfsa closed 10 months ago

haorenfsa commented 10 months ago

/cc @mintcckey

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4be02a4) 80.06% compared to head (1f5c271) 80.08%.

Files Patch % Lines
pkg/controllers/milvus_controller.go 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #51 +/- ## ========================================== + Coverage 80.06% 80.08% +0.02% ========================================== Files 47 47 Lines 4880 4881 +1 ========================================== + Hits 3907 3909 +2 + Misses 820 818 -2 - Partials 153 154 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sre-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, mintcckey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment