search

zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
33 stars 20 forks source link

Add affinity to the checker batch job #58

Closed dgomer closed 6 months ago

dgomer commented 6 months ago

The Helm chart values.yaml file allows setting affinity for the deployment. This affinity should also carry over to the checker batch job.

We use affinity with a multi-architecture cluster to ensure jobs run on architecture they are built for. The milvus-operator image does not currently have an ARM version, so we need affinity to ensure that it does not attempt to run on ARM nodes, otherwise you end up with random batch job failures if they get scheduled onto inappropriate architecture.

sre-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgomer To complete the pull request process, please assign haorenfsa after the PR has been reviewed. You can assign the PR to them by writing /assign @haorenfsa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sre-ci-robot commented 6 months ago

Welcome @dgomer! It looks like this is your first PR to zilliztech/milvus-operator 🎉

dgomer commented 6 months ago

Closing this while I wait for management approval :)