Update kafka.go to fix typo and update config for external Kafka Connection in SASL mode

zilliztech / milvus-operator

The Kubernetes Operator of Milvus.

https://milvus.io

Apache License 2.0

45 stars 23 forks source link

Update kafka.go to fix typo and update config for external Kafka Connection in SASL mode #72

Closed devartistgon closed 8 months ago

sre-ci-robot commented 8 months ago

Welcome @SahilDevgon! It looks like this is your first PR to zilliztech/milvus-operator 🎉

haorenfsa commented 8 months ago

Hi @SahilDevgon, before we can merge your patch, please sign off your commits. check this doc for detail: https://github.com/apps/dco

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5793bb9) 80.23% compared to head (a2e1fdf) 80.23%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #72 +/- ## ======================================= Coverage 80.23% 80.23% ======================================= Files 47 47 Lines 4918 4918 ======================================= Hits 3946 3946 Misses 818 818 Partials 154 154 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

haorenfsa commented 8 months ago

about CI failure: the v2.3.6 milvus image has critical bugs, so they deleted this tag to avoid being used. should be fixed after #73 merged

sre-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, SahilDevgon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment