zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
45 stars 23 forks source link

Rolling querynode 1 by 1 using 2 deployments #74

Closed haorenfsa closed 8 months ago

sre-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 8 months ago

Codecov Report

Attention: 165 lines in your changes are missing coverage. Please review.

Comparison is base (5af6827) 80.23% compared to head (0ba0b54) 80.80%.

:exclamation: Current head 0ba0b54 differs from pull request most recent head 4c1b8eb. Consider uploading reports for the commit 4c1b8eb to get more accurate results

Files Patch % Lines
pkg/controllers/status_cluster.go 38.09% 24 Missing and 2 partials :warning:
pkg/controllers/component_condition.go 0.00% 22 Missing :warning:
pkg/controllers/query_node.go 91.45% 12 Missing and 5 partials :warning:
pkg/controllers/error_detail.go 0.00% 13 Missing :warning:
pkg/controllers/query_node_util.go 95.23% 9 Missing and 4 partials :warning:
pkg/controllers/conditions.go 29.41% 9 Missing and 3 partials :warning:
pkg/controllers/deployments.go 36.84% 8 Missing and 4 partials :warning:
pkg/controllers/rollout_util.go 91.66% 7 Missing and 4 partials :warning:
pkg/controllers/setup.go 0.00% 8 Missing :warning:
apis/milvus.io/v1beta1/label_annotations.go 85.36% 4 Missing and 2 partials :warning:
... and 7 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #74 +/- ## ========================================== + Coverage 80.23% 80.80% +0.56% ========================================== Files 47 52 +5 Lines 4918 5839 +921 ========================================== + Hits 3946 4718 +772 - Misses 818 940 +122 - Partials 154 181 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.