zilliztech / milvus-operator

The Kubernetes Operator of Milvus.
https://milvus.io
Apache License 2.0
45 stars 23 forks source link

Fix reconcile with sidecar or configmap volume #81

Closed haorenfsa closed 7 months ago

sre-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-operator/blob/main/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 7 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c982af5) 80.79% compared to head (38c8de8) 80.79%.

Files Patch % Lines
pkg/controllers/k8s_default_values.go 85.71% 3 Missing :warning:
pkg/controllers/deployment_updater.go 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #81 +/- ## ======================================= Coverage 80.79% 80.79% ======================================= Files 52 53 +1 Lines 5852 5874 +22 ======================================= + Hits 4728 4746 +18 - Misses 942 946 +4 Partials 182 182 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.