Aristarhys
commented
3 years ago @snazzyfox @sayanchk please review
Closed Aristarhys closed 3 years ago
Aristarhys
commented
3 years ago @snazzyfox @sayanchk please review
The goal of this PR to unblock never versions of python with "small blood"
Things really get better after after merging PRs below as 3.6, 3.7 now using built in wheels, 3.7 seems to be unlocked already 👍🏻
https://github.com/zillow/luminaire/pull/76
3.8 need to build wheel initially for scipy, thus build deps should be installed first, after that using wheel from cache
3.9(fails to install scikit-learn completely)Various runs
https://github.com/zillow/luminaire/runs/1974082747?check_suite_focus=true - checking linter works as expected 👍🏻
https://github.com/zillow/luminaire/runs/1973251631?check_suite_focus=true - check better caching as described in https://medium.com/ai2-blog/python-caching-in-github-actions-e9452698e98d
Note 3.8 install dependencies time is 18 min but wheels status
done, instead ofDEPRECATION: scipy was installed using the legacy 'setup.py install' method, because a wheel could not be built for it.as seen in https://github.com/zillow/luminaire/runs/1971165453?check_suite_focus=true 👍🏻https://github.com/zillow/luminaire/runs/1973424828?check_suite_focus=true - check next build using cache and deps for 3.8 is now 7s 👍🏻
https://github.com/zillow/luminaire/runs/1973722601?check_suite_focus=true - 3.9 failure run
https://github.community/t/expected-waiting-for-status-to-be-reported/18001 - setting for checks should be adjusted - it's stuck now