search

zillow / react-slider

Accessible, CSS agnostic, slider component for React.
https://zillow.github.io/react-slider
MIT License
891 stars 232 forks source link

React 15.5 #102

Closed nikitatrifan closed 7 years ago

nikitatrifan commented 7 years ago

Hi guys, I'm just updated React to v15.5 and it's throwing this error below -

Warning: ReactSlider: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

Could you fix it please?

fluse commented 7 years ago

And

Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

Bjorgvin commented 7 years ago

I noticed the PR-104 from @spiderbites, but how prop-types and create-react-class are imported didn't seem to comply with the spirit of the project; Hope it's ok that I added my own PR-105

If this isn't merged soon, @mpowaga, my version can used like "react-slider": "Bjorgvin/react-slider#master" in your package.json

Bjorgvin commented 7 years ago

@mpowaga when can we expect this to be added to a version on npm? Also, I'm looking at npmjs/react-slider and it says the latest version is 0.7.0 but the github/releases shows v0.6.1 as the latest.

Anyway... would like to have a clean package.json with a simple reference to react-slider "react-slider": "react-slider"

...hopefully soon and thanks for the merge.