zillow / react-slider

Accessible, CSS agnostic, slider component for React.
https://zillow.github.io/react-slider
MIT License
892 stars 231 forks source link

prevent default page scroll when using ArrowUp/ArrowDown #119

Closed dominicfraser closed 6 years ago

dominicfraser commented 7 years ago

When the page height is greater than the viewport height ArrowUp and ArrowDown are used to move the page up and down for a key board user.

Currently when the focus is on the slider handle ArrowUp and ArrowDown can have the unintended side effect of also scrolling the page as well as moving the handle.

By adding e.preventDefault only the handle will move, and the page will not scroll. Once the user tabs away from the slider the page can again be scrolled using the arrow keys.