search

zillow / react-slider

Accessible, CSS agnostic, slider component for React.
https://zillow.github.io/react-slider
MIT License
891 stars 232 forks source link

Accessibility: Support aria-labels #125

Closed atlidohop closed 6 years ago

atlidohop commented 6 years ago

Addresses issue #124

mpowaga commented 6 years ago

Thanks @atlidohop! Looks good to me. Just one nitpick - what's the purpose of making aria props default to empty string? Shouldn't they stay undefined when not provided?

atlidohop commented 6 years ago

Good point, @mpowaga . Changes coming up.

atlidohop commented 6 years ago

Beware, this is untested code, but works for my use case. How can I run index.html?

atlidohop commented 6 years ago

This should work for all cases now @mpowaga . I also made some changes to make this package more accessible to contributing developers. Let me know if I'm breaking something somewhere else. 😅

mpowaga commented 6 years ago

I appreciate the effort to make it easier to contribute but React and other packages must be declared as peerDependencies. Can you open an issue where we can discuss how we can improve development experience?

atlidohop commented 6 years ago

Sure thing. I'll revert the changes in package.json.

atlidohop commented 6 years ago

@mpowaga Thanks for good comments, much better now. 😄