With inverted vertical slider the arrow keys move the slider in the wrong direction

zillow / react-slider

Accessible, CSS agnostic, slider component for React.

https://zillow.github.io/react-slider

MIT License

891 stars 232 forks source link

With inverted vertical slider the arrow keys move the slider in the wrong direction #143

Closed gauthierm closed 5 years ago

gauthierm commented 5 years ago

I'm making a volume control that is vertical and inverted. When the handle is focused, the arrow keys move the slider the opposite of what is on the screen (down moves up, up moves down).

StarNeit commented 5 years ago

Hi @gauthierm Did you find reason of issue?

gauthierm commented 5 years ago

@StarNeit Yes. The issue is the keyboard handlers do not check this.props.inverted before adding or removing values.

gauthierm commented 5 years ago

Fixed in https://github.com/mpowaga/react-slider/pull/144

stonebk commented 5 years ago

Fixed with #147