zillow / react-slider

Accessible, CSS agnostic, slider component for React.
https://zillow.github.io/react-slider
MIT License
891 stars 232 forks source link

`onChange` nor `onAfterChange` gets invoked when `value` changes #194

Closed coolsp closed 3 years ago

coolsp commented 4 years ago

Description

When using value for controlled components and changing the linked state value the thumb gets updated however onChange nor onAfterChange gets invoked by the ReactSlider component. The expected behavior would for both on methods to get invoked as the value changed.

stonebk commented 3 years ago

This is expected behavior IMO -- a controlled <input> does not fire onChange events when you change the value, not sure why we would.