search

zillow / react-slider

Accessible, CSS agnostic, slider component for React.
https://zillow.github.io/react-slider
MIT License
883 stars 231 forks source link

UNSAFE_componentWillReceiveProps replaced in favor of getDerivedStateFromProps #196

Closed Wmaileq closed 3 years ago

Wmaileq commented 3 years ago

This PR removes annoying warnings.

stonebk commented 3 years ago

@Wmaileq thanks for the contribution! The changes look good, can you just update the commit message to follow conventional commits guidelines (for our changelog generation)? Something like this:

refactor: UNSAFE_componentWillReceiveProps replaced in favor of getDerivedStateFromProps

Fixes #193

Wmaileq commented 3 years ago

@stonebk Done!

stonebk commented 3 years ago

@Wmaileq sorry to nitpick, but can you make it lower-case "refactor:"? I'm worried that standard-version might be case sensitive on the types

Wmaileq commented 3 years ago

@Wmaileq sorry to nitpick, but can you make it lower-case "refactor:"? I'm worried that standard-version might be case sensitive on the types

I thought about it too, but: https://www.conventionalcommits.org/en/v1.0.0/#specification (15) But i will rename for consistency @stonebk Done!

stonebk commented 3 years ago

Good to know, thanks!

stonebk commented 3 years ago

react-slider@1.0.10

stonebk commented 3 years ago

Had to revert this change due to https://github.com/zillow/react-slider/issues/197

Started working on a solution, but it needs some more thought: https://github.com/zillow/react-slider/pull/198