fix: onChange now returns the correct value when used as a controlled…

zillow / react-slider

Accessible, CSS agnostic, slider component for React.

https://zillow.github.io/react-slider

MIT License

883 stars 231 forks source link

Closed stonebk closed 3 years ago

stonebk commented 3 years ago

… component

Fixes #197

stonebk commented 3 years ago

I'm not sure that this entirely fixes things. Some open questions:

What is the expected behavior of onBeforeChange and onAfterChange for a controlled component?
What is the expected behavior of onChange when you press and hold a key?

These become quite unclear when you set value to a fixed value and then start seeing how things work.

stonebk commented 3 years ago

Clicking on the track does not work with this change.

stonebk commented 3 years ago

react-slider@1.1.1