search

zillow / react-slider

Accessible, CSS agnostic, slider component for React.
https://zillow.github.io/react-slider
MIT License
883 stars 231 forks source link

fix: ignore meta key events in keyDown handler #231

Closed zschreur closed 3 years ago

zschreur commented 3 years ago

On macOS the meta key is often used for commands. Thus if doing an action such as undo the slider will not update until the cmd key is released.

zschreur commented 3 years ago

Can you update the commit message to follow conventional commits guidelines.

Updated!

zschreur commented 3 years ago

Sorry I thought you meant the PR description. The commit message should be good now.

stonebk commented 3 years ago

react-slider@1.3.1

stonebk commented 3 years ago

Thanks @zschreur for the contribution!

zschreur commented 3 years ago

Thank you!