Make `prop-types` a normal dependency instead of peer/dev

zillow / react-slider

Accessible, CSS agnostic, slider component for React.

https://zillow.github.io/react-slider

MIT License

883 stars 231 forks source link

Make `prop-types` a normal dependency instead of peer/dev #253

Closed axelboc closed 2 years ago

axelboc commented 2 years ago

Fix #245

I'm following the recommendations of the prop-types package: https://github.com/facebook/prop-types#how-to-depend-on-this-package.

The prop-types package remains properly externalised in the ES/UMD bundles, most likely thanks to this line in create-react-styleguide.

kris-ellery commented 2 years ago

Hi there! react-slider still uses create-react-styleguide v7. We plan to update it to v8 very soon. It will fix any dependency issue and provide new CJS/ESM builds.

axelboc commented 2 years ago

Awesome! I'll close this, then.