search

zillow / react-slider

Accessible, CSS agnostic, slider component for React.
https://zillow.github.io/react-slider
MIT License
883 stars 231 forks source link

React 18 support #257

Closed adrianmanduc closed 2 years ago

adrianmanduc commented 2 years ago

Hello. It would be nice to add React v18 to peerDependencies to make using this package easier in projects using React 18. Thanks

kris-ellery commented 2 years ago

Hi @adrianmanduc, we need to first test it with React 18 and make sure there are no regressions. We'll update peerDependencies accordingly.

gabrielmicko commented 2 years ago

Hey @kris-ellery any update on this?

DavidChouinard commented 2 years ago

@kris-ellery we're also held up on this to migrate our app to React 18 🙏

kris-ellery commented 2 years ago

Added React 18 as a valid peerDependency. I tested every documentation example in a small Vite-powered app. However, please report any React 18 incompatibilities.

DavidChouinard commented 2 years ago

Fantastic thank you!!