Closed Ryan-Haig12 closed 1 year ago
@kris-ellery Management on my team is eager to get this functionality into our app, are you the person for me to ask to pr this change?
@Ryan-Haig12 can you add supporting tests for this use case?
@Ryan-Haig12 can you add supporting tests for this use case?
I sure can, I will get on that as soon as I get around to it. Thanks man
@kris-ellery I added some basic tests here. React-test-renderer is far from my strongest skill so if there is a simpler way to do this or you would like me to change anything please let me know
@Ryan-Haig12 thank you, I'll do my best to merge in few open PRs and craft a release this week. Apologies for the delay.
@kris-ellery No huge rush from me, my team doesn't need this functionality for a few months.
I appreciate you taking a look!
@kris-ellery friendly reminder
@kris-ellery Friendly reminder, we're still a few weeks out from our release that requires this functionality for our app. Management would just like to get this in sooner rather than later if possible
You're the man @kris-ellery thanks a bunch!
Thank you for your patience. Merged and published in v2.0.5
Fix for the issue: https://github.com/zillow/react-slider/issues/286
Tested on localhost:6060 and all sliders still work as expected
https://zillow.github.io/react-slider/ See the slider "An inverted slider with custom marks" and attempt to press the left and right arrow keys, that behavior will now be inverted with this change