zillow / react-slider

Accessible, CSS agnostic, slider component for React.
https://zillow.github.io/react-slider
MIT License
891 stars 232 forks source link

Default style looks bad. #91

Closed jakehm closed 4 years ago

jakehm commented 7 years ago

Why can't the slider come with a default style that doesn't look so bad? So if I wanted to use the component, I wouldn't have to do the styling myself.

shin-monkey commented 7 years ago

Maybe we all could share the styling made for this.

alexisross commented 7 years ago

Hi, here an example (but the counter disappear for me, anyway not sure it's a problem of css): react-slider-orange-pill

.horizontal-slider {
    width: 100%;
    height: 42px;
    border: 2px solid #ff7200;
    border-radius: 25px;
}

.handle {
    font-size: 0.9em;
    text-align: center;
    background-color: #ff7200;
    color: yellow;
    cursor: pointer;
    top: 02px;
    width: 34px;
    height: 34px;
    border-radius: 20px;
    border: 2px solid white;
}

.handle.active {
    border: 5px solid white;
}

.bar {
    position: relative;
    background: #ff7200;
}

.bar.bar-1 {
    background: #a5a5a5;
}

.horizontal-slider .bar {
    top: 6px;
    height: 26px;
    border-radius: 16px;
    margin: 0 6px;
}
hinok commented 7 years ago

I wouldn't say that it's an issue. In my opinion this is a big plus that react-slider can be easily customized because it is shiped without styles.

my-slider

shin-monkey commented 7 years ago

@hinok could you please share this style? It looks great!

JoaoPintoM commented 7 years ago

@hinok yes plz, can we have this style ?

hinok commented 7 years ago

@shin-monkey @JoaoPintoM I'm sorry but I cannot share it because it's internal wrapper for a product of one of my clients.

I just showed this gif as a proof that it's good that Default style looks bad.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.