search

zilpay / zil-pay

ZilPay browser extension enables browsing Zilliqa blockchain enabled websites.
https://zilpay.io
Other
3 stars 1 forks source link

Printing seed button prints blank #51

Closed ghost closed 2 years ago

ghost commented 3 years ago

Describe the bug Printing seed button prints blank.

To Reproduce Steps to reproduce the behavior:

  1. Open FF
  2. Click Create
  3. Click Print
  4. See the blank page

https://user-images.githubusercontent.com/86328181/133015018-80783acd-5a27-4309-9f2e-92703892a25f.mov

Possible Solution https://github.com/zilpay/zil-pay/blob/0fc15823b00ce3c36186c027a081a8fa01b3b299/src/mixins/printer.js#L112-L114

You may want to use win.document.write

e.g.

win.document.write("<p>This is 'MsgWindow'. I am 200px wide and 100px tall!</p>");

Reference: https://www.w3schools.com/jsref/met_win_open.asp

Expected behavior Should be able to print seed.

Desktop (please complete the following information):

hicaru commented 3 years ago

thanks for your issue, i will fix it on new release.