search

zilverline / react-tap-event-plugin

Instant TapEvents for React
http://facebook.github.io/react/
MIT License
1.07k stars 110 forks source link

Synthetic Event breaks in IE11 #113

Open juanca opened 6 years ago

juanca commented 6 years ago

Do you want to request a feature or report a bug?

Bug.

What is the current behavior?

SyntheticEvent.js breaks in IE11.

Object.assign is explicitly used to extend the prototype of SyntheticEvent. https://github.com/zilverline/react-tap-event-plugin/blob/f7ed5c560011590d24e07480686b234b2f3ea1f5/src/SyntheticEvent.js#L123

What is the expected behavior?

SyntheticEvent.js should work.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

Broken in React 16 + IE11 + react-tap-event-plugin. It used to work in React 15 + IE11 + react-tap-event-plugin.

Is the recommended approach to use babel to polyfill Object.assign?

See https://github.com/facebook/react/issues/11788

adipascu commented 6 years ago

I am having the same issue when running on Android 5.1. Please consider avoiding Object.assign or build the dist bundle with babel.