Closed gaearon closed 6 years ago
Hi @gaearon, thanks for letting us know. You've already warned for this in #112 so we knew this was coming. We're not planning on supporting >=16.4 and will make this clear in the README. I think it's time to move away from this plugin anyway since the problem has gone away mostly.
Lol I forgot about that issue, sorry for the spam. Feel free to close :-)
No worries, thanks for the reminder 😄
You suggested turning this plugin into a <Tappable>
component but I feel that would create a bigger migration path than simply replacing onTouchTap
to onClick
. Since the problem is already solved by most browsers.
I've already experimented with a userland onTouchTap
replacement but performance was very poor. The main problem is the name of the handler on the lower case React elements (div
, button
etc), this has to be replaced with the actual handler before rendering.
So I think it's time to end this plugin.
Everything will come to an end. Anyway, it works good on my app. Thank you very much!
I am using react 16.0.0 on an old project but it wont work ...
We renamed some of the internal top level types in https://github.com/facebook/react/pull/12629 so the plugin in its current form will break. It's not a semver-major change because this plugin was never supported officially and relies on private APIs that can change in any patch.