search

zilverline / react-tap-event-plugin

Instant TapEvents for React
http://facebook.github.io/react/
MIT License
1.07k stars 110 forks source link

react Newest is 16.4.1，but react-tap-event-plugin newest is 16.4.0 #122

Open tezml opened 6 years ago

tezml commented 6 years ago

npm report errors and click Invalid.

ajoshi0 commented 6 years ago

any update on this warning

npm WARN react-tap-event-plugin@3.0.3 requires a peer of react@^16.0.0-0 < 16.4.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-tap-event-plugin@3.0.3 requires a peer of react-dom@^16.0.0-0 < 16.4.0 but none is installed. You must install peer dependencies yourself
dupski commented 6 years ago

See README. This library is not compatible with react 16.4, it is only compatible with react 16.3 and below

tezml commented 6 years ago

@dupski i want to say. if compatible to react so bad, this plugs afraid difficult to spread！

dupski commented 6 years ago

@tezml most browsers have now fixed the issue this library was designed to solve, so it is not needed any more and has been deprecated.

1003657663 commented 6 years ago

@dupski but ios has 300ms delay when i click,and user-scalable="no" can't resolve this problem. do you have better function to resolve this problem whitout touchTap or fastclick. because I try react-fastclick and happend ghost click;

dupski commented 6 years ago

Recent versions of safari don't have this issue AFAIK. Unfortunately I don't know what version of safari they fixed it in.

I had the problem with a Cordova app, but solved it using WKWebView: https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/README.md