search

zilverline / sequent

CQRS & event sourcing framework for Ruby
https://sequent.io
MIT License
541 stars 58 forks source link

Adding support for Rails 7.2 #417

Closed evsasse closed 2 months ago

evsasse commented 2 months ago

Hey @lvonk 👋, we are planning to to update our app to Rails 7.2 soon, and saw that it wasn't compatible with the Sequent main branch yet.

Here are some tentative changes on adding support to it. Let me know if there is anything that you'd approach differently, and I can try to make the changes myself.

I will continue my internal effort to update our app here in the next couple days, and will also be able to confirm if these changes is all we ended up needing.

lvonk commented 2 months ago

Hi, we are also about to start upgrading to the new AR version (and ruby 3.3). I will keep you posted on our finds.

lvonk commented 2 months ago

@evsasse Can you give me access to your fork? Or shall I create a new PR for the 7.2 upgrade? The issue with the quote_table_name can be solved by calling: Sequent.configuration.event_record_class.connection.quote_table_name(table_name).

I am still looking into the issue with the active?

evsasse commented 2 months ago

Can you give me access to your fork?

Sent you an invite 👍.

But feel free to create a branch on your side and close this PR if it makes things easier for you.

lvonk commented 2 months ago

But feel free to create a branch on your side and close this PR if it makes things easier for you.

Ok, will do this then, is a bit easier.

I looked into the active? flag and didn't find the resolution yet. I will reach out to the rails devs and see if they know what changed. We only use this method in the spec btw so I think we are good to go, but I want to make sure.

lvonk commented 2 months ago

But feel free to create a branch on your side and close this PR if it makes things easier for you.

I will create a new PR and close this one then, is a bit easier... thanks for the work!

lvonk commented 1 month ago

@evsasse fyi: I asked a question here https://github.com/rails/rails/issues/52858

eduscrakozabrus commented 1 month ago

I would like to inquire if there have been any updates regarding compatibility with Rails 7.2. Currently, I am encountering a NotImplementedError when attempting to use Sequent.aggregate_repository.load_aggregate(ENV["DEV_ACCOUNT_ID"]).

Is there any temporary workaround available to resolve this issue and get things working smoothly?

lvonk commented 1 month ago

Hi @eduscrakozabrus this PR https://github.com/zilverline/sequent/pull/420 is work in progress, we are conducting the last tests. We encountered no errors so far and fixes the issue you mention. I expect this to be merged and released somewhere next week (unless we encounter any issues).