search

zim-desktop-wiki / zim-desktop-wiki

Main repository of the zim desktop wiki project
http://zim-wiki.org
GNU General Public License v2.0
1.95k stars 369 forks source link

Skip favicon.ico in tests/attachmentbrowser #2625

Closed oturpe closed 4 months ago

oturpe commented 5 months ago

gdk-pixbuf 2.42.11 removes support for multiple less common image formats, including ICO. Skip that format in thumbnail generation tests to make the test pass.

Other than the test failure, Zim remains functional with gdk-pixbuf 2.42.11. Attachment Browser still works even for ICO files. The thumbnails naturally fail to show up, but otherwise the browser remains functional. ICO files cannot be attached to pages anymore, instead error dialog with text File type not supported: image/x-icon is displayed.

oturpe commented 5 months ago

The test failure at MSYS2 Python 3.x on windows-latest is:

======================================================================
FAIL: runTest (tests.widgets.TestFileDialog.runTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:/a/zim-desktop-wiki/zim-desktop-wiki/tests/widgets.py", line 414, in runTest
    self.assertIsInstance(adapt_from_oldfs(myfolder), LocalFolder)
AssertionError: None is not an instance of <class 'zim.newfs.local.LocalFolder'>

That is not related to this change at all, and I see the same in other recent pull requests, too. So I don't think there is anything to fix in this pull request because of that.