search

zim32 / mysql.dart

MySQL client for Dart written in Dart
BSD 3-Clause "New" or "Revised" License
67 stars 18 forks source link

add support for unix socket on pool connection #47

Open long1eu opened 1 year ago

zim32 commented 1 year ago

Hi. Thanks for this PR. The only think is that in the main branch there should be no logging. All logging is in separate branch called logging )

Can you remove logger from this PR?

long1eu commented 1 year ago

You're right. On it.

On Fri, 14 Apr 2023 at 12:04, zim32 @.***> wrote:

Hi. Thanks for this PR. The only think is that in the main branch there should be no logging. All logging is in separate branch called logging )

Can you remove logger from this request?

— Reply to this email directly, view it on GitHub https://github.com/zim32/mysql.dart/pull/47#issuecomment-1508268078, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACG2OVT7IKYMSR4FTZMLO33XBEOJJANCNFSM6AAAAAAU5XHSNE . You are receiving this because you authored the thread.Message ID: @.***>

andrecnogueira commented 1 year ago

what's the status on this PR? This would unblock folks like me who would like to use unix socket on GCP to connect to SQL instances