Fix broken tar options on non-Debian based distributions.

zimbatm / ffmpeg-static

Scripts to build ffmpeg with all the deps statically (webm + h264 included)

ISC License

508 stars 253 forks source link

Fix broken tar options on non-Debian based distributions. #55

Closed andreipoe closed 7 years ago

andreipoe commented 7 years ago

It appears that --no-overwrite-dir cannot be used with --keep-old-files. On Debian, this is silently ignored, but it may cause the script to fail on other distributions. Switching to --skip-old-files should provide the intended behaviour: do not replace files if they already exist.

See http://lists.gnu.org/archive/html/bug-tar/2015-08/msg00004.html and https://lists.gnu.org/archive/html/bug-tar/2016-05/msg00015.html for reference.

zimbatm commented 7 years ago

Now that I think about it, these options are not supported on macOS (bsdtar)

zimbatm commented 7 years ago

Merged as it's an improvement