search

zimeon / iiif

IIIF Image API reference implementation and Python library
GNU General Public License v3.0
55 stars 15 forks source link

coverage segfaults on py3.3 only for one test #22

Closed zimeon closed 7 years ago

zimeon commented 8 years ago

Have been unable to get the coverage part of tests to pass on 3.3, get:

test03_do_first (tests.test_manipulator_pil.TestAll)
Test first step. ... /home/travis/virtualenv/python3.3.5/lib/python3.3/site-packages/PIL/OleFileIO.py:400: ResourceWarning: unclosed file <_io.BufferedReader name='testimages/test1.png'>
  for keyword, var in list(vars().items()):
/home/travis/build.sh: line 45:  6666 Segmentation fault      (core dumped) coverage run --source=iiif --omit=iiif/manipulator_netpbm.py setup.py test
The command "coverage run --source=iiif --omit=iiif/manipulator_netpbm.py setup.py test" exited with 139.

even though python setup.py test works fine.

zimeon commented 8 years ago

Still the case with https://travis-ci.org/zimeon/iiif/jobs/147588135 : 

...
/home/travis/virtualenv/python3.3.5/lib/python3.3/site-packages/PIL/OleFileIO.py:400: ResourceWarning: unclosed file <_io.BufferedReader name='testimages/test1.png'>
  for keyword, var in list(vars().items()):
/home/travis/build.sh: line 45:  6613 Segmentation fault      (core dumped) python setup.py test
The command "python setup.py test" exited with 139.
...

Don't know how to debug this and suspect that it may be a travis issue rather than a real issue.

zimeon commented 8 years ago

Have removed py3.3 in a86a9e66aa

zimeon commented 7 years ago

I'm going to ignore this one and forget about python 3.3. The python 3 series is already on 3.6 so I don't see a compelling reason why 3.3. is important.