search

zimeon / ocfl-py

OCFL tools in Python
MIT License
20 stars 7 forks source link

Handle case of multiple conformance declarations more gracefully #92

Closed zimeon closed 2 years ago

zimeon commented 2 years ago

Current code throws and error without an E0XX code:

ocfl-py> ./ocfl-validate.py extra_fixtures/1.1/bad-objects/E003_two_declarations
ERROR:ocfl-validate:Bad path extra_fixtures/1.1/bad-objects/E003_two_declarations (more than one 0= declaration file)

(Have added extra_fixtures/1.1/bad-objects/E003_two_declarations in add_v1_1_support branch, see https://github.com/OCFL/spec/issues/581)

zimeon commented 2 years ago 
ocfl-py> ./ocfl-validate.py extra_fixtures/1.1/bad-objects/E003_two_declarations
[E003b] OCFL Object includes more that one file that looks like an object declaration (got 2), using version 1.1 (see https://ocfl.io/1.0/spec/#E003)
[E038] OCFL Object root inventory `type` attribute has wrong value (expected https://ocfl.io/1.1/spec/#inventory, got https://ocfl.io/1.0/spec/#inventory) (see https://ocfl.io/1.0/spec/#E038)
INFO:ocfl.object:OCFL object at extra_fixtures/1.1/bad-objects/E003_two_declarations is INVALID

E038 will show up or not based on whether declaration selected matches type or not