Reduce code to minimal, follow other Zim themes

zimfw / minimal

A minimal fork of subnixr's minimal prompt theme.

GNU General Public License v3.0

8 stars 3 forks source link

Reduce code to minimal, follow other Zim themes #5

Closed ericbn closed 2 years ago

ericbn commented 2 years ago

[X] I've followed Zim's code style guidelines.

Use typeset -g to set global variables, avoiding warnings when WARN_CREATE_GLOBAL is set.
Use add-zle-hook-widget to bind widgets with Zsh >= 5.3.
Minimal customization.
Use prompt-pwd.

What was removed:

Hash in git commit indicator (just show HEAD instead).
Git ahead/behind indicator and customization via MNML_DIV_COLOR.
Customization of components via MNML_PROMPT and MNML_RPROMPT.
"Magic enter", and customization via MNML_INFOLN and MNML_MAGICENTER.

ericbn commented 2 years ago

186 lines removed, only 55 lines left. ;- )

@PatTheMav, @kaznovac, anyone following this repo, let me know what do you think of this extreme change. Are you still using this prompt? Am I removing anything you'd still like to have?

ericbn commented 2 years ago

Code is also outdated since beginning of 2019 in relation to upstream. I'm planning to include at least two updates that were added since then:

Fix bug preventing hyphen to be printed
Add customization via MNML_BGJOB_MODE

PatTheMav commented 2 years ago

Changes look fine to me so far, I haven't kept up with what happened upstream given that I'm personally not using this theme for quite some time now.

Was the "magic enter" functionality removed upstream as well?

ericbn commented 2 years ago

Hi @PatTheMav, thanks for your feedback. And no, the "magic enter" was not removed from upstream. In fact:

This was removed from here to imitate upstream:

Hash in git commit indicator (just show HEAD instead).
Git ahead/behind indicator and customization via MNML_DIV_COLOR.

This was removed from here to simplify the code, but still exists upstream:

Customization of components via MNML_PROMPT and MNML_RPROMPT.
"Magic enter", and customization via MNML_INFOLN and MNML_MAGICENTER.

This was added here to imitate upstream:

Fix bug preventing hyphen to be printed.
Add customization via MNML_BGJOB_MODE.

PatTheMav commented 2 years ago

I guess I'm fine with the changes, but I have no idea how many actual users might rely on the "magic enter" functionality. Removing it kinda breaks the idea of it being a port of the original, but I'd leave that judgement to actual users (and possible GitHub issues coming from that) to decide.

ericbn commented 2 years ago

Good point. It might be simple to reimplement the "magic enter" without the customizations. I'll give it a try and include it back.

kaznovac commented 2 years ago

Amazing work, as alawys @ericbn

I've seldomly used the "magic enter" feature (I just keep forgetting it's there...).

Personally I prefer no-code over the feature I will 'eventually' need/use; but in this case missing "magic enter" might pose a surprise to an existing minimal theme user (unless it's clearly stated. e.g. similarly to the asciiship) - so it might be worth implementing.

In the spirit of minimal I'd vote to implement "magic enter" as a separate module (even better if theme agnosticism can be achieved), and clearly state this module is theme only.

ericbn commented 2 years ago

@kaznovac, I like the idea of moving "magic enter" to a separate module. Thanks!