update filter names to strictly follow iati-standard element names.

zimmerman-team / IATI.cloud

IATI datastore powered by Apache Solr. Automatically Extracts and parses IATI XML files referenced in the IATI Registry & refreshed every 3 hrs. IATI is a global initiative to improve the transparency of development and humanitarian resources and their results for addressing poverty and crises.

https://datastore.iati.cloud

MIT License

32 stars 28 forks source link

update filter names to strictly follow iati-standard element names. #1643

Closed luminhan-zz closed 4 years ago

luminhan-zz commented 5 years ago

Please check all of them and update them to follow iati-standard element names.

url
id
iati_identifier
reporting_organisation
title
descriptions
participating_organisations
other_identifier
activity_status
budget_not_provided
activity_dates
contact_info
activity_scope
recipient_countries
recipient_regions
locations
sectors
tag
country_budget_items
humanitarian
humanitarian_scope
policy_markers
collaboration_type
default_flow_type
default_finance_type
default_aid_type
default_tied_status
budgets
planned_disbursements
capital_spend
transactions
related_transactions
document_links
related_activities
legacy_data
conditions
results
crs_add
fss
last_updated_datetime
xml_lang
default_currency
humanitarian
hierarchy
linked_data_uri
secondary_reporter
aggregations
dataset
publisher
published_state
transaction_types

siemvaessen commented 5 years ago

@luminhan does this relate to #1438 btw?

luminhan-zz commented 5 years ago

@siemvaessen yes, but we only changed names that are totally different from iati-standard like reporting-organisation-identifier then, not names with s.

siemvaessen commented 5 years ago

@luminhan please review the ones in OIPA db-model that are consistent with the IATI standard convention and provide a list of the fields that are currently plural rather than single. @samuele-mattiuzzo changing the plurals to single will have a major impact on the system both work and test-wise, so we will not be changing this w/o proper scoping first.

siemvaessen commented 5 years ago

Relates to #1641

siemvaessen commented 4 years ago

@luminhan could you start an impact analysis.

siemvaessen commented 4 years ago

Ok, this will work will start on 9/12

JoshStanleyDevInit commented 4 years ago

@siemvaessen Just a reminder that we would like a document with all the new parameter names so that we can cross-check this prior to implementation.

Thanks!

luminhan-zz commented 4 years ago

https://docs.google.com/spreadsheets/d/14SNYG5n4e582nbVijBzllUitQBA8iW0_w2N6WMmrFlE/edit#gid=0

siemvaessen commented 4 years ago

Many tests broken and @stephanoshadjipetrou will review & fix those while moving forward.

siemvaessen commented 4 years ago

Ok, @stephanoshadjipetrou fixed almost all the tests, @luminhan will pick up 2 Django specific test to be fixed.

siemvaessen commented 4 years ago

@stephanoshadjipetrou needs to run a validation review on this.

PetyaKangalova commented 4 years ago

@siemvaessen looks to me that the filter names do follow the iati-standard elements. Can you give just an update or link to the validation review you mentioned above?

siemvaessen commented 4 years ago

@PetyaKangalova that was a reference for @stephanoshadjipetrou as this ticket had a PR (Pull Request) at the time.

PetyaKangalova commented 4 years ago

Ok, filter names look okay.