zimmerman-team / IATI.cloud

IATI datastore powered by Apache Solr. Automatically Extracts and parses IATI XML files referenced in the IATI Registry & refreshed every 3 hrs. IATI is a global initiative to improve the transparency of development and humanitarian resources and their results for addressing poverty and crises.
https://datastore.iati.cloud
MIT License
32 stars 28 forks source link

Value tests #2225

Closed siemvaessen closed 4 years ago

siemvaessen commented 4 years ago

I see 100,00 in many fields while raw data is reported as 100. This is a conversion issue. Original values must be original values, datastore can never alter them ever.

See this CSV file for example:

siemvaessen commented 4 years ago

See original raw

XM-DAC-3-1-285892-34348

@ http://preview.iatistandard.org/index.php?url=http%3A//iati.um.dk/api/v2/files/iati7.xml

search for XM-DAC-3-1-285892 (removed the -34348)

From the original XML://

  <iati-activity last-updated-datetime="2020-04-29T05:01:56" xml:lang="en" default-currency="DKK" humanitarian="true" hierarchy="2">
    <iati-identifier>XM-DAC-3-1-285892-34348</iati-identifier>
    <reporting-org xml:lang="en" ref="XM-DAC-3-1" type="10">
      <narrative>'Ministry of Foreign Affairs, Denmark'</narrative>
    </reporting-org>
    <title xml:lang="en">
      <narrative>UNHCR COVID-19 2020, engagement</narrative>
    </title>
    <description xml:lang="en" type="1">
      <narrative />
    </description>
    <participating-org xml:lang="en" ref="XM-DAC-3-1" type="10" role="1">
      <narrative>Ministry of Foreign Affairs, Denmark</narrative>
    </participating-org>
    <participating-org xml:lang="en" ref="XM-DAC-XM-DAC | OECD Development Assi" type="40" role="2">
      <narrative>United Nations Office of the United Nations High Commissioner for Refugees</narrative>
    </participating-org>
    <other-identifier ref="DK-1" type="A1">
      <owner-org ref="XM-DAC-3-1">
        <narrative>N/A</narrative>
      </owner-org>
    </other-identifier>
    <activity-status code="2" />
    <activity-date type="2" iso-date="1900-01-01" />
    <contact-info type="1">
      <organisation>
        <narrative>Humanitære indsatser, Civilsamfund og Engagement (HCE)</narrative>
      </organisation>
      <person-name>
        <narrative>NA</narrative>
      </person-name>
      <telephone>NA</telephone>
      <email>NA</email>
    </contact-info>
    <recipient-region code="998" percentage="100" />
    <sector xml:lang="en" vocabulary="1" code="72010" percentage="100">
      <narrative>Material relief assistance and services </narrative>
    </sector>
    <country-budget-items vocabulary="4">
      <budget-item code="946" percentage="100">
        <description>
          <narrative />
        </description>
      </budget-item>
    </country-budget-items>
    <collaboration-type code="1" />
    <default-flow-type code="10" />
    <default-finance-type code="110" />
    <default-aid-type code="C01" />
    <budget type="1" status="2">
      <period-start iso-date="2020-04-01" />
      <period-end iso-date="2020-06-30" />
      <value value-date="2020-04-01" currency="DKK">100000000</value>
    </budget>
    <related-activity ref="XM-DAC-3-1-285892" type="1" />
    <crs-add>
      <channel-code>41121</channel-code>
    </crs-add>
  </iati-activity>

and the XML DS output has the same issue, add data:

<?xml version="1.0" encoding="UTF-8"?><iati-activities version="2.03">
<iati-activity xml:lang="en">
<iati-identifier>XM-DAC-3-1-285892-34348</iati-identifier>
      <reporting-org ref="XM-DAC-3-1" type="10"><narrative>Ministry of Foreign Affairs, Denmark</narrative></reporting-org>

      <title><narrative>UNHCR COVID-19 2020, engagement</narrative></title>

      <description type="1" />

      <participating-org ref="XM-DAC-XM-DAC&#160;|&#160;OECD Development Assi" role="2" type="40"><narrative>United Nations Office of the United Nations High Commissioner for Refugees</narrative></participating-org>
      <participating-org ref="XM-DAC-3-1" role="1" type="10"><narrative>Ministry of Foreign Affairs, Denmark</narrative></participating-org>

      <other-identifier ref="DK-1" type="A1"><owner-org ref="XM-DAC-3-1"><narrative>N/A</narrative></owner-org></other-identifier>

      <activity-status code="2" />

      <activity-date iso-date="1900-01-01" type="2" />

      <contact-info type="1"><organisation><narrative>Humanit&#230;re indsatser, Civilsamfund og Engagement (HCE)</narrative></organisation><person-name><narrative>NA</narrative></person-name><telephone>NA</telephone><email>NA</email></contact-info>

      <recipient-region code="998" percentage="100.00" vocabulary="1" />

      <sector code="72010" percentage="100" vocabulary="1"><narrative>Material relief assistance and services </narrative></sector>

      <country-budget-items vocabulary="4" />

      <collaboration-type code="1" />

      <default-finance-type code="110" />

      <default-aid-type code="C01" vocabulary="1" />

      <budget status="2" type="1"><period-start iso-date="2020-04-01" /><period-end iso-date="2020-06-30" /><value currency="DKK" value-date="2020-04-01">100000000.00</value></budget>

      <related-activity ref="XM-DAC-3-1-285892" type="1" />

      <crs-add><channel-code>41121</channel-code></crs-add>
    </iati-activity>
</iati-activities>