zimmerman-team / IATI.cloud

IATI datastore powered by Apache Solr. Automatically Extracts and parses IATI XML files referenced in the IATI Registry & refreshed every 3 hrs. IATI is a global initiative to improve the transparency of development and humanitarian resources and their results for addressing poverty and crises.
https://datastore.iati.cloud
MIT License
32 stars 28 forks source link

Change code field in model ActivityTag #2520

Closed luminhan-zz closed 3 years ago

luminhan-zz commented 3 years ago

The code field in model ActivityTag is set to the max_lenght of 5. According to iatistandard this field has no restriction on length.

solution: set that field length to a suitable value and make migration.

sylvanr commented 3 years ago

Set it to 255 for now. Should allow for any given code length.

According to the django docs, 255 should be long enough. https://docs.djangoproject.com/en/dev/ref/databases/#character-fields the following code lists contain up to 5 characters: https://iatistandard.org/en/iati-standard/203/codelists/unsdg-goals/ https://iatistandard.org/en/iati-standard/203/codelists/unsdg-targets/

ghost commented 3 years ago

:tada: This issue has been resolved in version 5.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: