zimmerman-team / IATI.cloud

IATI datastore powered by Apache Solr. Automatically Extracts and parses IATI XML files referenced in the IATI Registry & refreshed every 3 hrs. IATI is a global initiative to improve the transparency of development and humanitarian resources and their results for addressing poverty and crises.
https://datastore.iati.cloud
MIT License
32 stars 28 forks source link

Default currencies not being used for USD conversion of transaction values? #2592

Closed sarahshamiso closed 3 years ago

sarahshamiso commented 3 years ago

Ran this query:

https://iatidatastore.iatistandard.org/search/transaction?q=(activity_recipient_country_code:(SO) OR transaction_recipient_country_code:(SO)) AND transaction_type:(3 4) AND (default_humanitarian:(1) OR transaction_humanitarian:(1))&wt=csv&rows=9581

Would expect all transaction values to be converted to USD except in instances where the currency is not available to do the conversion.

In this file there are 343 transactions with transaction values but have "0" for the converted USD value.

Taking a look at a few of the activities, they all appear to have default currencies that don't seem to have been pulled in to convert the transaction value to USD.

Example: http://d-portal.org/q.xml?aid=NL-KVK-27108436-A-05875-02:SO

In this example you can see that there is a default currency but in the output from the QB, the currency value (EUR) is blank and none of the transaction values have been converted to USD.

Is it that default currencies are not being applied to transaction values where the currency is not provided for the transaction or is there another issue here?

amy-silcock commented 3 years ago

Thanks for raising Sarah. If no specific currency is stated, the default should be used

sylvanr commented 3 years ago

ETA 1 day