Fixes zimmski/tavor#54 - Change filter interface

yblein commented 9 years ago

Change the fuzzing filter interface so that filters only return one token. Filters can now merge multiple tokens as they wish before returning.

Fixes #54

zimmski commented 9 years ago

Looks like errcheck does more than before, I will fix that first before looking at the PR

zimmski commented 9 years ago

This looks really good! Please have a look at my comments.

zimmski commented 9 years ago

Well done!

Some pointers for the future:

It is better if you develop each feature/issue in separate branch
Give the branch a reasonable name
The PR title should be sufficient to know what is done "Change the Filter interface so that filters are responsible for merging their tokens" would be long but explicit.
It is better for the projects commit history if you squash and redefine your commits (some projects enforce this)
Add a comment when you are done with a suggestion and in general if a reviewer should take another look. Sadly the review workflow of GitHub is not that good yet so such comments are necessary.

zimmski / tavor