zinc-collective / compensated

Create value. Get Paid.
Other
13 stars 1 forks source link

Developer may integrate Compensated with their existing Rails App without wrapping it in custom model classes #52

Open zspencer opened 4 years ago

zspencer commented 4 years ago

Now that we've gotten 3~4 implementations within Rails apps; it seems like a reasonable next step will be to create a Rails Engine that encourages a domain model.

Suggested Steps:

I'm comfortable merging this into 0.X in small steps or one big PR; so long as it's not making significant changes to the compensated-ruby directory.

user512 commented 4 years ago

This is our understanding between compensated-ruby & compensated-rails.

  1. compensated-rails will depend on compensated-ruby.
  2. compensated-ruby will be responsible for core logic, including parsing webhook event.
  3. compensated-rails will be generating required tables and provide reader methods.
  4. Existing users of compensated-ruby will be able to keep using that gem can expect further future code improvement without needed to transition to compensated-rails.

@zspencer Does these align with what you were thinking?

zspencer commented 4 years ago

Yep! this matches what I was imagining perfectly!