🎉💡📝✅ Sprout cucumber-js for system-testing compensated

zspencer commented 4 years ago

See: https://github.com/zinc-collective/compensated/issues/79

I went back and forth between cucumber-js and cucumber-rb; and I wound up choosing cucumber-js because JavaScript is the lingua-franca of the web; and it seems like it makes it a bit easier for folks to get started contributing to systems testing when we use a language that they're familiar with.

This also adds the system tests to CI.

This could be merged as-is; but if it doesn't get merged I'll probably do a few more things:

[x] Wire in the steps so it actually runs the compensated library when compensated apply gets called
[ ] Figure out how to make assertions against a fake version of the Stripe API so we don't hit the real API in our tests.

zspencer commented 4 years ago

@cjoulain - Are you sure the scenarios are passing locally? They are not wired in, so I would expect them to be coming back as "pending."

I'm assuming that because you have approved this you read the code and believe it's structured well enough for you to comfortably change; so I'm going to merge as-is and I can finish wiring in the fake stripe-api stuff later.

cjoulain commented 4 years ago

Good point! I misspoke. I should have said more that there was an absence of errors rather than the tests passed (when I ran them, there were 3 passes and 6 skipped scenarios and in the cross-selling feature). The structure looks good to me.

zinc-collective / compensated

🎉💡📝✅ Sprout cucumber-js for system-testing compensated #80