search

zinc-collective / convene

An Operating System for the Solidarity Economy
https://convene.zinc.coop
Other
56 stars 19 forks source link

Scripts and configurations to run Jitsi locally #138

Closed anaulin closed 3 years ago

anaulin commented 3 years ago

This PR adds configuration files and scripts to build and run a local dockerized Jitsi Meet, and documentation about how to use this. This work was motivated by one of the items in https://github.com/zinc-collective/convene/issues/40, which will require us to work on configuring authentication of some sort between convene-web and Jitsi.

I've also taken the liberty of trying to improve the organization (and amount of emojis) in the main README. My main goal was to make that document a little bit more "scannable", and to make it a little clearer to new folks wanting to develop in this repo that the bulk of developer documentation is under convene-web. I'm not sure if I succeeded in those goals, and I'm curious to hear what y'all think.

anaulin commented 3 years ago

@user512 @zspencer please review 🙏

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

user512 commented 3 years ago

I am not familiar with Docker and will need one of you to help me to get run this locally.

anaulin commented 3 years ago

Thanks for the review, @zspencer ! Not sure if the merge was intentional or reflexive, but I'll follow up with a second PR addressing some of the stuff in the comments (at the very least fix the typo!).

@user512 maybe we can help you during today's pairing session?

KellyAH commented 3 years ago

I'm super late to this conversation but I just ❤️ the readme improvements and dockerfile you added in this PR! Awesome job! It looks so much better. Love the emojis!

Tho I still find it confusing that the readme doesn't clearly explain what the zinc collective is and its relationship to convene and its other products. I'll try updating the readme with that info.

And I can now hopefully spin up the app in a dockerfile and not have install tons more app versions on my local. Thanks for so many awesome improvements!

anaulin commented 3 years ago

Aww, thanks for the kind words, @KellyAH !

zspencer commented 3 years ago

Thanks for the review, @zspencer ! Not sure if the merge was intentional or reflexive, but I'll follow up with a second PR addressing some of the stuff in the comments (at the very least fix the typo!).

At present, we work from the "if it's safe to merge, merge." This may not be our long-term practice, but establishing a pattern of relatively-low-friction small changes feels like a powerful way to make contributing more accessible. That said, it could also make contributing feel less safe; so I'd be interested in hearing your thoughts on how it feels to you.

anaulin commented 3 years ago

At present, we work from the "if it's safe to merge, merge." This may not be our long-term practice, but establishing a pattern of relatively-low-friction small changes feels like a powerful way to make contributing more accessible. That said, it could also make contributing feel less safe; so I'd be interested in hearing your thoughts on how it feels to you.

I suspected, but wasn't sure, that you were defaulting to "merge if safe", which I like. Thanks for clarifying. I wonder if it might make sense to be explicit about that somewhere, maybe in the Contributing guidelines?

I agree that it makes contributing feel more welcoming. To me this doesn't make it feel unsafe to contribute (I try to be careful about being very explicit if I think something would be unsafe to merge), but of course this is just one opinion.

zspencer commented 3 years ago

@anaulin - Good point re: Contributing guidelines. I could have sworn I had it in there, but I guess not. I've created https://github.com/zinc-collective/www.zinc.coop/issues/60 and maybe I'll even wind up getting to it someday!