Closed zspencer closed 3 years ago
Not sure what is the ideal place to record this, but recording here a note from @colombene after demoing the v0 of the UI: We may want to gray out the “access code” input when the room is not locked.
SonarCloud Quality Gate failed.
5 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
1 Code Smell
No Coverage information
0.0% Duplication
Not sure what is the ideal place to record this, but recording here a note from @colombene after demoing the v0 of the UI: We may want to gray out the “access code” input when the room is not locked.
@anaulin - Thanks for letting me know! I've added a checkbox to the Github Issue for Locking Rooms: https://github.com/zinc-collective/convene/issues/40 so that we don't lose track of that part of the acceptance criteria.
Going to make one more changes related to comments and merge.
Regarding safe to merge or not, I think it's safe to merge as long as we have feature flip against it and only expose new feature for @colombene to review. And @colombene can always review the Convene Demo and avoid confusion on multiple review app links or slate review app links.
For grayed-out treatment of key, please also gray out text. For current treatment, try #A6A6A6 instead of black.
Thanks @colombene! Is #a6a6a6 intended to be our default font color? Is there a part of the Adobe XD that declares our color pallette?
I'm going to refine my XD file to be better about consistency (color, text, components, etc.) and will check how to share that info out. That hex color above is sorta preliminary. I need to bump up the design resolution to make color specs more accurate (just posted in Slack about this).
There's a bit more to do here, for instance we want to make sure that only people who have the existing room key can unlock the room or change the room key.
This can probably be done by re-using some of the
waiting room
?Or should we start pulling in pundit and using that for permissioning before we wind up rolling our own?
TODO: