🌸✨ `Members`: `Invitation` email should convey which `Space` and `Person` it came from

[anaulin]

• https://github.com/zinc-collective/convene/issues/1514

The current Space invitation email doesn't have much info about who / what is actually inviting you and to what, unless you already know what Convene is:

It would be good to:

• [x] add the Space name to the subject line (e.g. "You are invited to SPACE NAME", instead of "Invitation email") https://github.com/zinc-collective/convene/pull/1483
• [x] add the name of the invitor to either the subject line (e.g. "PERSON NAME invites you SPACE NAME") or the "from" text (e.g. "Convene Support on behalf of PERSON NAME")

[anaulin]

@KellyAH assigning this to you in case you are looking for something to do, but don't feel obliged to do it!

[KellyAH]

Ooo exciting! I've never worked with the Rails Mailer templates before. Thanks so much @anaulin ! I'll give it a shot today and this weekend! 😄

[anaulin]

@KellyAH thank you! Don't hesitate to send questions if you get stuck.

And in case you aren't aware of this feature: Rails mailer previews can be very helpful, see https://guides.rubyonrails.org/action_mailer_basics.html#previewing-emails

[zspencer]

Great catch! I've linked the card to the "nearest-upstream-leaf" in the product garden wiki thing. We probably should split Invitations into it's own high level issue since Members is getting pretty overloaded; but I will do that "someday when I think about it."

[sentry-io[bot]]

Sentry issue: CONVENE-1H

[zspencer]

Sentry issue: CONVENE-1H

Whoops! Apparently sending an email with a from field missing an actual email address does not uhhh.... work...

We'll probably want to:

• [x] Fix the bug: https://github.com/zinc-collective/convene/issues/1515
• [x] Investigate adjusting maildev to angrily reject malformed emails: https://github.com/zinc-collective/convene/issues/1518