search

zinc-collective / convene

An Operating System for the Solidarity Economy
https://convene.zinc.coop
Other
56 stars 19 forks source link

🌸✨ `Members`: `Invitation` email conveys which `Space` and `Person` it came from #1483

Closed KellyAH closed 12 months ago

KellyAH commented 1 year ago
before

After

Screenshot 2023-05-21 at 8 20 59 PM
KellyAH commented 1 year ago

IMHO adding the invitor name to the Subject could be too wordy. What do ya'll think? @anaulin @zspencer

too wordy maybe

anaulin commented 12 months ago

What about putting the invite name in the "from" field I stead?

It says "Neighborhood support", but maybe it could say something like "INVITOR NAME via NEIGHBORHOOD". Or some other wording that you prefer. The main point is to convey both the invite name somewhere in the "from" or the "subject".

For inspiration, here are some screencaps of invites from other systems that I found in my inbox:

Screenshot_20230520_095704_Gmail.jpg

Screenshot_20230520_095719_Gmail.jpg

Screenshot_20230520_095913_Gmail.jpg

Screenshot_20230520_100013_Gmail.jpg

KellyAH commented 12 months ago

I will rework this on sunday 5/21 from @anaulin 's and @zspencer 's suggestions, feedback and requirements. I think I can meet everyone's needs.

KellyAH commented 12 months ago

My bad 🤦‍♀️ . I confused the From field for the email ending salutation. Thanks for the examples @anaulin they helped a lot.

Ok I fixed it up. Hope it's better now!

KellyAH commented 12 months ago

🤔 Darn browser tests in responding_to_invitations.feature is failing in parts of code I don't think I touched.

AssertionError [ERR_ASSERTION]: By(css selector, *[aria-label="Configure Space"])

Couldn't find email {"to":"katara-9d14ec59-5507-4416-8e8d-74ce32c3c734@example.com"}

Can't see the browser when tests run in code spaces. 😞 I'll need to spin up local again.....

zspencer commented 12 months ago

Sometimes the browser specs flake, If you re-run them they often pass. I've kicked off a re-run to see if that's the case here.

zspencer commented 12 months ago

OK, with the re-run I'm guessing it's because of how we're searching the sent mail in the test that's failing. I'll take a stab at getting it fixed and push a PR this-a-way.

zspencer commented 12 months ago

I think this is good to go! We could probably do a follow up PR to try and make the output better when the system tests' email query files (like, why does it just output the "to" when there is also a "text" matcher?! And how do we get a better stack trace?!) but I didn't want to get nerd-sniped by that until I wrap up the tests for fixing the quantitys.

sentry-io[bot] commented 11 months ago

Sentry issue: CONVENE-1H