✨ `Space` add "Website Settings" section and enforce ssl checkbox

[KellyAH]

• for https://github.com/zinc-collective/convene/issues/1473

Changes

• Add "Website Settings" section
• Add enforce ssl checkbox to Spaces edit page
• only space members can see the new "Website Settings" section.
• [x] Update space policy with :enforce_ssl permitted param
• [x] add logic update the spaces table enforce_ssl with the checkbox value boolean (dependent on to https://github.com/zinc-collective/convene/pull/1479)
• [x] add unit tests

[KellyAH]

Test Cases to test on Local

• If a user checks the Enforce SSL checkbox on /spaces/<space-name>/edit, and then clicks the Save changes button, the checkbox stays checked and the DB space table enforce_ssl value is true
• If a user unchecks the Enforce SSL checkbox on /spaces/<space-name>/edit, and then clicks the Save changes button, the checkbox stays unchecked and the DB space table enforce_ssl value is false
• Refresh/force refresh /spaces/<space-name>/edit preserves the Enforce SSL checkbox state.

[KellyAH]

@zspencer I forgot to ask you where on the /spaces/<space-name>/edit page do you want the Enforce SSL checkbox to be added? Utilities Section a different section, or a new Security section?

[anaulin]

It feels like we're starting to need a new "general space settings" section. (With maybe a better / more concise title, probably.)

[zspencer]

For now an "Operator Only Settings" section feels like maybe the right place; that way we could also expose the branded_domain field there

[KellyAH]

Will continue on sunday 5/21

[KellyAH]

@zspencer should I add browser tests or any unit tests for the new "Operator Only Settings" section? Or is it too early

[zspencer]

It would be good to have a spec/requests/spaces_controller_request_spec#update test to make sure that the enable_ssl flag gets set to true when the form comes through; but I think a full system test would be too much since we're probably going to move this around soon anyway.

[zspencer]

Maybe this is actually "Website Settings" and not "Operator Only Settings" 🙃

[KellyAH]

Maybe this is actually "Website Settings" and not "Operator Only Settings" 🙃

Renamed to "Website Settings" in the code and UI in 5910f5c4041f214cda4f1f36fc3995a15e8136f3