search

zinc-collective / convene

An Operating System for the Solidarity Economy
https://convene.zinc.coop
Other
56 stars 19 forks source link

🥗 `Marketplace`: Test `Seller` receives `Order` in their `Square` Point of Sale #1936

Closed rosschapman closed 5 months ago

rosschapman commented 6 months ago

Follow up to https://github.com/zinc-collective/convene/pull/1909

rosschapman commented 5 months ago

This test looks great! I'd love more permutation tests deeper in the stack; but having a shot-across-the-bow in the request specs that confirms we're interacting with the square gem correctly is highly valuable in it's own right.

Yep! This is definitely step 1 of N toward confident coverage. And it helped us clean up the interface between the controller/caller code and the Square subsystem of classes.

anaulin commented 5 months ago

It looks like the tests added in this PR are failing in CI on main: image https://github.com/zinc-collective/convene/actions/runs/7108075091/job/19350699926

zspencer commented 5 months ago

Oh I think I know what's happening! Dependabot doesn't get the same secrets that the contributors have access to. I can't remember what I did with Stripe; but it was either:

A) I skipped the tests when the environment variables weren't set, or B) I gave dependabot the secrets C) I designed the tests to pass without Stripe (Which I don't think is true because the system test definitely depends on Stripe working? Maybe?)

zspencer commented 5 months ago

I added the secrets from actions to dependabot and I think that fixes it! https://github.com/zinc-collective/convene/settings/secrets/dependabot

anaulin commented 5 months ago

Ah, forgot all about that. Thanks @zspencer !

rosschapman commented 5 months ago

Oh boy, thanks @zspencer for the rescue there.

zspencer commented 5 months ago

Computaaaahs