zinc-collective / convene

An Operating System for the Solidarity Economy
https://convene.zinc.coop
Other
57 stars 21 forks source link

✨ `SectionNavigation`: Customizing `Section` links #2037

Open rosschapman opened 11 months ago

rosschapman commented 11 months ago

Use Case

Marketing and sales

Notes

Customizing button color would complement customized images and vendor branding, but that should be considered as part of a larger behavior that introduces theming in a centralized place. See https://github.com/zinc-collective/convene/issues/2037#issuecomment-1859018471.

zspencer commented 11 months ago

I think we should hold off on button color until we actually figure out a way to do theming. Otherwise yea! Letting people change the Text / Icon / Image on a per-SectionLink basis would be great.

P.s. This title appears to overlap significantly with https://github.com/zinc-collective/convene/issues/1961, but I think what it really wants to be is a child of https://github.com/zinc-collective/convene/issues/1988, and it could be rephrased to something like "SectionNavigation: Customizing Section links"

rosschapman commented 11 months ago

P.s. This title appears to overlap significantly with https://github.com/zinc-collective/convene/issues/1961, but I think what it really wants to be is a child of https://github.com/zinc-collective/convene/issues/1988, and it could be rephrased to something like "SectionNavigation: Customizing Section links"

I literally forgot to change the title that's all whoops 😆

zspencer commented 11 months ago

I've updated this to indicate that it should be done as part of the SectionNavigation gizmo, and added in customizing the Image as things worth customizing.