Marketplace: Distributor updates products

[KellyAH]

TODO:

• [x] fix edit icon https://github.com/zinc-collective/convene/pull/942/commits/9ca29c3a7ed0c7d22d2765df481382fc55a7f1d9

• [x] add translation for edit product, thus when hover over edit button, it says "edit product" https://github.com/zinc-collective/convene/pull/942/commits/33a4c6d9b306019a70083efa5f8ea41744187d07

• [x] fix unable to find scopeMarketplace::ProductPolicy::Scope`

  

• [x] Add and test Marketplace::ProductPolicy#edit?

• [x] add request specs for Marketplace::ProductsController to spec/furniture/marketplace/products_controller_request_spec.rb

[KellyAH]

I will try to fix the icon and translation Friday evening 11/18 on my own.

[zspencer]

Feel free to reach out in Discord if you have any questions! I'll likely be a bit distracted (game night with my book club friends!) but should be able to do async slow-vibes text support.

[KellyAH]

IDK why the CI pipe is unhappy. I didn't change anything in the area it's complaining about. 😞

SessionNotCreatedError: Expected browser binary location, but unable to find binary in default location, no 'moz:firefoxOptions.binary' capability provided, and no binary flag set on the command line
    at Object.throwDecodedError (/home/runner/work/convene/convene/node_modules/selenium-webdriver/lib/error.js:524:15)
    at parseHttpResponse (/home/runner/work/convene/convene/node_modules/selenium-webdriver/lib/http.js:587:13)
    at Executor.execute (/home/runner/work/convene/convene/node_modules/selenium-webdriver/lib/http.js:515:28)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  remoteStacktrace: ''

[zspencer]

It looks like firefox isn't being installed so we can't run the browser tests. I'm installing it here: https://github.com/zinc-collective/convene/pull/946

[zspencer]

OK! Now that #946 is merged, you should be able to rebase or merge main into this branch and get CI back to ga-reen!

[KellyAH]

In Wednesday's 11/23 session, let's also talk about the constant ActiveRecord::RecordNotUnique Errors I keep getting every time I spin up local. I keep needing to do rails db:reset and bin/setup a few time in a row to get convene FE up. Weird.

[KellyAH]

Kelly - TODO: add request specs for remaning marketplace/cart_products and marketplace/products routes. refactor asserts on existing request specs tests.