zincware / MDSuite

A post-processing engine for particle simulations
https://mdsuite.readthedocs.io/
Eclipse Public License 2.0
36 stars 7 forks source link

[WIP] Fran graphs #518

Open Fratorhe opened 2 years ago

Fratorhe commented 2 years ago

This PR should not be merged (YET). I have a few questions and I think this is the easiest way to assess them.

I have implemented calculators for the search of neighbors per atom, and for the rings (initial development by Hamish). The current implementation does not use TF (only numpy and scipy).

Questions:

Summary of additions and changes

How to test this pull request

Functional tests using a fullerene have been implemented. Further tests could be implemented using DataHub if needed. The lammpstraj file added so far is very small.

In examples, I included as well a C59 structure (basically removing an atom from the C60).

SamTov commented 2 years ago

@Fratorhe Maybe we can have a call next week or so and go over it together with the molecule mapping stuff somewhere in mind as it looks like there are some nice crossovers that we can take advantage of.