search

zinggAI / zingg

Scalable identity resolution, entity resolution, data mastering and deduplication using ML
GNU Affero General Public License v3.0
950 stars 120 forks source link

Block and stop word test #859

Closed Nitish1814 closed 2 months ago

Nitish1814 commented 2 months ago

Block and StopWord Tests

vikasgupta78 commented 2 months ago

as discussed I am not convinced that we need IWithSession and WithSession in the main code. Also naming needs to be fixed. Do an impact analysis and discuss with @sonalgoyal

vikasgupta78 commented 2 months ago

there was already a class TestBlock in zingg spark core? Why is that not being reused?

vikasgupta78 commented 2 months ago

PojoToArrayConverter => repetitive code for child and parent class

vikasgupta78 commented 2 months ago

there was existing TestStopWords class why it has been deleted instead of renamed / moved to maintain history

Nitish1814 commented 2 months ago

there was already a class TestBlock in zingg spark core? Why is that not being reused?

just restructured package, reused same file only !

Nitish1814 commented 2 months ago

there was existing TestStopWords class why it has been deleted instead of renamed / moved to maintain history

1: TestStopWords first made generic 2: Renamed to TestStopWordsBase 3: Moved to common

Nitish1814 commented 2 months ago

there was already a class TestBlock in zingg spark core? Why is that not being reused?

1: TestBlock first made generic 2: Renamed to TestBlockBase 3: Moved to common

Nitish1814 commented 2 months ago

PojoToArrayConverter

removed