issues
search
zingolabs
/
zingolib
An API and test-app that exposes zcash functionality for app consumption
MIT License
14
stars
21
forks
source link
fixed bugs in note selection
#1185
Closed
Oscar-Pepper
closed
3 months ago
Oscar-Pepper
commented
3 months ago
fixes bug where underflow can occur on calculating new target value
fixes bug where largest note is added and new target is not checked before adding extra notes
fixes bug where a non-dust note is added assuming a grace input is available but could be from wrong pool to single selected note
fixes bug where non-dust of value 5000 can be selected for dust
main note selection algorythm now ignores dust to reach target value
breaks when all unselected ntoes are dust
better error handling with NonNegativeAmount for balance calculations and appropriate InputSourceError variants
removes unecessary option and option handling from note transformation allowing for more specific and correct error variant